Skip to content

Resolve config file paths from the consuming app - #27

Merged
neilvcarvalho merged 1 commit into
thoughtbot:mainfrom
elalemanyo:fix/config-path-resolution
Aug 11, 2026
Merged

Resolve config file paths from the consuming app#27
neilvcarvalho merged 1 commit into
thoughtbot:mainfrom
elalemanyo:fix/config-path-resolution

Conversation

@elalemanyo

Copy link
Copy Markdown
Contributor

Summary

Fixes relative config-file paths so they are resolved from the consuming Rails app instead of the action repository.

Context

The action runs importmap-update from github.action_path. Because of that, the default .github/importmap-updates.yml path was looked up inside the action checkout. If missing, the config fell back to defaults, causing patch and minor updates to be grouped even when the consuming repo configured strategy: individual.

Changes

  • Resolve relative config paths against RAILS_ROOT
  • Keep absolute config paths unchanged
  • Add regression coverage for loading config from an explicit base directory

Verification

  • bundle exec ruby -Itest test/config_test.rb
  • bundle exec rake

@neilvcarvalho neilvcarvalho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks!

@neilvcarvalho
neilvcarvalho merged commit 26449af into thoughtbot:main Aug 11, 2026
6 checks passed
@elalemanyo
elalemanyo deleted the fix/config-path-resolution branch August 11, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants