This repository was archived by the owner on Mar 2, 2018. It is now read-only.
Allow closing modals by clicking on background window#236
Closed
kennyadsl wants to merge 1 commit intothoughtbot:masterfrom
Closed
Allow closing modals by clicking on background window#236kennyadsl wants to merge 1 commit intothoughtbot:masterfrom
kennyadsl wants to merge 1 commit intothoughtbot:masterfrom
Conversation
kennyadsl
force-pushed
the
close-modal
branch
from
7fe0741 to
1226fe9
Compare
Contributor
|
@kennyadsl nice! I like this. Looking at it now. |
Contributor
Author
|
@Magnus-G great! let me know if you need me to change anything. |
Contributor
|
Thanks @kennyadsl, It was merged in 1e026e6 |
Magnus-G
pushed a commit
that referenced
this pull request
Feb 13, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds the ability to close modals by clicking on background window. It basically just triggers a
modal-statechecked change. StopPropagation onmodal-innerelement is needed to allow clicking inside themodal-innerwithout causing the modal to close (inner is inside window so the click would be triggered as well). Coffescript is generated withrake coffee.P.S. I know you want to keep javascript as minimal as possible but I think this could be useful for someone else. I'll totally understand if this is not accepted. 😄