This repository was archived by the owner on Mar 2, 2018. It is now read-only.
fixes modal window closing bug#239
Closed
kennyadsl wants to merge 1 commit intothoughtbot:masterfrom
Closed
Conversation
Contributor
|
Thank you @kennyadsl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, #236 and #221 together are causing a bug (currently also on refills website 💀 ). When the modal is closed by clicking outside the modal inner the "window-open" class is not removed correctly from body. I changed the "click" binding event into "change" for the "modal-state" input. This way it will correctly close the background window, even if the modal is closed programmatically.