Insert an inspect on the exit status#13
Merged
elisuh merged 14 commits intothoughtbot:masterfrom Feb 16, 2023
Merged
Conversation
Closed
This conversion is done by Transpec 3.4.0 with the following command:
transpec
* 52 conversions
from: obj.should
to: expect(obj).to
* 33 conversions
from: == expected
to: eq(expected)
* 3 conversions
from: obj.should_not
to: expect(obj).not_to
* 2 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 1 conversion
from: =~ /pattern/
to: match(/pattern/)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
…arting with Ruby 3.0
Remove posix runner and unsupported posix-spawn gem
Introduce GitHub Actions for CI
remove unused dependency 'bourne' and change 'mocha' to rspec-mocks
For thoughtbot#12. This would be helpful to confirm that we are getting a `nil` exit status. Thanks!
elisuh
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12. This would be helpful to confirm that we are getting a
nilexit status. Thanks!