Skip to content

Fix metadata extract KeyError crash + cut dependent-search wall-clock#325

Merged
jp-spotter merged 2 commits into
thoughtspot:devfrom
jp-spotter:fix/metadata-dependent-robustness-and-concurrency
Jul 22, 2026
Merged

Fix metadata extract KeyError crash + cut dependent-search wall-clock#325
jp-spotter merged 2 commits into
thoughtspot:devfrom
jp-spotter:fix/metadata-dependent-robustness-and-concurrency

Conversation

@jp-spotter

Copy link
Copy Markdown
Collaborator

Two follow-ups to #324, surfaced by the live test on a large cluster:

  • KeyError: 'created' crash. ts_metadata_dependent direct-accessed created/modified/author/etc.; some dependents come back missing them → crash. Now skipped + counted (DependentObject requires those non-null, so no schema change). This bug was masked before — the old code aborted at the fan-out and never reached it.
  • Wall-clock. Dependent phase ran ~55 min at concurrency 10. Bumped to 20 for the dependent phase only (each request stays small). Starting point — needs live re-measure/tune.

Still to do after merge: re-dispatch fetch-metdata against dev to confirm it completes and measure the new runtime.

@jp-spotter
jp-spotter requested a review from a team as a code owner July 22, 2026 16:52
@jp-spotter
jp-spotter merged commit 0e97b38 into thoughtspot:dev Jul 22, 2026
3 checks passed
@jp-spotter
jp-spotter deleted the fix/metadata-dependent-robustness-and-concurrency branch July 22, 2026 17:34
jp-spotter added a commit that referenced this pull request Jul 22, 2026
…t-robustness-and-concurrency"

This reverts commit 0e97b38, reversing
changes made to 3617504.
jp-spotter added a commit that referenced this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant