Tolerate null created/modified in searchable extract - #327
Merged
jp-spotter merged 1 commit intoJul 23, 2026
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
searchable metadataextract crashes mid-run (KeyError: 'created') when the ThoughtSpot APIomits a timestamp for certain object types — observed:
FEEDBACKdependents omitcreated,LOCAL_GROUPgroups omitmodified. One missing field aborts the whole extract, so affectedclusters get no data at all.
Fix
Treat
created/modifiedas a nullable class in the searchable models, and coerce through ashared helper that tolerates absent/null:
validators.utc_from_millis()— epoch-millis → UTC datetime, orNonewhen absent (guards the/1000againstKeyError/TypeError).validators.ensure_datetime_is_utcnow short-circuitsNone, so model validators inherit it.created/modified→OptionalonUser,Group,Tag,DataSource,MetadataObject,DependentObject; transformers usesrc.get(...)via the helper.A batch extract should capture whatever is available (null included) rather than crash.
No contract change
Noneloudly (their fields staynon-optional; pydantic rejects at the type check).
Validation
tests/test_searchable_transformer.py); full suite green.the
LOCAL_GROUP/modifiedcase that previously failed.Scope
Searchable only. The shared
validatorschange enables the same treatment for the other tools'transformers (archiver, scriptability, user-management, …) as a follow-up.