Skip to content

Remove dead retry_on_httpx_errors decorator on metadata fetch - #328

Merged
jp-spotter merged 1 commit into
thoughtspot:devfrom
jp-spotter:chore/remove-dead-fetch-retry
Jul 23, 2026
Merged

Remove dead retry_on_httpx_errors decorator on metadata fetch#328
jp-spotter merged 1 commit into
thoughtspot:devfrom
jp-spotter:chore/remove-dead-fetch-retry

Conversation

@jp-spotter

Copy link
Copy Markdown
Collaborator

Removes a dead retry decorator on workflows.metadata.fetch.

retry_on_httpx_errors wrapped fetch, but fetch raises ExceptionGroup (via
BoundedTaskGroup), which its retry_if_exception_type((ReadError, ConnectTimeout, HTTPStatusError)) predicate can never match — so it never fired (reraise=True propagated the
same exception either way). It was also redundant with the transport-layer retry in client.py,
which retries every request (idempotency-aware, exponential backoff + jitter, 429/503/502/504).

Pure deletion: the decorator, its definition, and the now-unused tenacity import. No behavior
change — per-request retries remain intact at the transport layer.

Retry / transport / workflow test suites green.

@jp-spotter
jp-spotter requested a review from a team as a code owner July 23, 2026 19:22
@jp-spotter
jp-spotter merged commit 6d6e3f2 into thoughtspot:dev Jul 23, 2026
3 checks passed
@jp-spotter
jp-spotter deleted the chore/remove-dead-fetch-retry branch July 24, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant