Remove dead retry_on_httpx_errors decorator on metadata fetch - #328
Merged
jp-spotter merged 1 commit intoJul 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a dead retry decorator on
workflows.metadata.fetch.retry_on_httpx_errorswrappedfetch, butfetchraisesExceptionGroup(viaBoundedTaskGroup), which itsretry_if_exception_type((ReadError, ConnectTimeout, HTTPStatusError))predicate can never match — so it never fired (reraise=Truepropagated thesame exception either way). It was also redundant with the transport-layer retry in
client.py,which retries every request (idempotency-aware, exponential backoff + jitter, 429/503/502/504).
Pure deletion: the decorator, its definition, and the now-unused
tenacityimport. No behaviorchange — per-request retries remain intact at the transport layer.
Retry / transport / workflow test suites green.