Correlate deploy TML-import results positionally, not by request_index - #330
Merged
jp-spotter merged 1 commit intoJul 23, 2026
Merged
Conversation
jp-spotter
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
searchable deploycommand crashes with an IndexError right after a successful TML import. It maps each import result back to the submitted TMLs by the result's request_index, but that value is a server-side ordinal rather than a position in the submitted list. It is sparse and can exceed the list length, so the lookup runs off the end.The fix maps results to TMLs positionally, by submission order, instead — matching how the existing import path already reports its results.
Verified with a unit test that reproduces the crash, and end-to-end against a live deploy: 21 of 21 objects imported, no crash.