Restore the terminal cursor when the progress tracker exits - #331
Merged
jp-spotter merged 1 commit intoJul 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a command that shows the progress tracker, the terminal cursor stays hidden. It is invisible on lenient terminals, but persists in strict emulators such as cloud shells until the user runs
reset.The tracker hides the cursor when it starts but never restores it on exit: its exit path refreshes the display but never calls the underlying
stop(), which is what shows the cursor again and halts the refresh thread.The fix calls
stop()on exit. A test asserts the cursor is restored.