Clarify extract failure messages and make skipped loads visible - #341
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract failure messages now say what was being fetched (dependents, details, permissions) rather than only the object type, and the end-of-run breakdown groups by both — the same columns are fetched by three phases, so the type alone couldn't say what was lost. A deliberately skipped load renders as "skipped -- incomplete extract" in the progress table instead of an ambiguous "--", and file-syncer runs are told to re-run rather than promised a merge. Verified live against a real cluster with forced read timeouts.