Fix the Inno Setup step, and let a dispatch attach to an existing release

[thpoll83]

Summary

All three Release runs failed at the same step, before anything was built — my bug in #2:

A newer version of InnoSetup (v6.7.1) is already installed.
Use --allow-downgrade or --force to attempt to install older versions.
Chocolatey installed 0/1 packages. 1 packages failed.
##[error]Process completed with exit code 1.

windows-latest already ships Inno Setup, so pinning --version=6.2.2 asked choco to downgrade; it refused and failed the step. I pinned it defensively without checking the runner image — the opposite of defensive.

Fix: install only when Inno Setup is genuinely absent, then assert the "%ProgramFiles(x86)%\Inno Setup 6\ISCC.exe" path that installer.csproj hardcodes. A future runner-image change now fails there, with a message naming the cause, instead of surfacing as a confusing msbuild error two steps later.

Recovering PK-0.9.16

The release is already published and has its crafted notes (publish_release.py sets title/body over the API, so that part succeeded independently of CI) — it just has no assets.

Re-running the failed release run won't help: it would replay the workflow file from that tag's commit, bug included. So workflow_dispatch now takes an optional tag input:

• empty → build the assets as artifacts, release nothing (the smoke test, unchanged)
• PK-0.9.16 → build and attach the assets to that existing release

So once this merges: Actions → Release → Run workflow, with tag = PK-0.9.16. That both proves the packaging path and finishes the release in one run. If you'd rather verify first, dispatch once with tag empty and check the artifacts, then dispatch again with the tag.

Testing

Still can't run a Windows build here, so the Inno Setup step is verified only against the failure log above. The steps after it — installer.csproj → iscc, the src/WinCompose-Setup-<ver>.exe path assertion, the portable packaging — have never executed, since the job died before reaching them. Expect the possibility of a second fix round; the dispatch path makes that cheap to iterate on.

---

Generated by Claude Code

Summary by Sourcery

Fix Windows release workflow to avoid failing when Inno Setup is already installed and allow manually dispatched runs to attach built assets to an existing release tag.

Bug Fixes:

• Prevent the Windows release job from failing when a newer Inno Setup version is preinstalled on the runner by only installing it if missing and asserting the expected path.

Enhancements:

• Add an optional tag input to the release workflow_dispatch so builds can attach assets to an existing release instead of only producing artifacts.
• Extend release notes and release creation steps to use the provided tag input, enabling recovery of previously published releases whose asset upload failed.

[sourcery-ai]

Sorry @thpoll83, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[coderabbitai]

Warning

Review limit reached

@thpoll83, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6cb1cad6-60da-492d-97b4-a52cdaf6c200

📥 Commits

Reviewing files that changed from the base of the PR and between 34def87 and e68d964.

📒 Files selected for processing (1)

• .github/workflows/release.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Reviewer's Guide

Adjusts the Windows release workflow to avoid failing when Inno Setup is preinstalled on the runner, and adds an optional workflow_dispatch input so a manual run can build assets and attach them to an existing release tag.

Sequence diagram for workflow_dispatch attaching assets to an existing release tag

sequenceDiagram
  actor Maintainer
  participant GitHubActions as GitHub_Actions_workflow
  participant ReleaseJob as release_job
  participant GitHubAPI as GitHub_API

  Maintainer->>GitHubActions: workflow_dispatch(tag = PK-0.9.16)
  GitHubActions->>ReleaseJob: start with inputs.tag = PK-0.9.16
  ReleaseJob->>ReleaseJob: set concurrency group = release-(github.event.release.tag_name || inputs.tag || github.ref_name)
  ReleaseJob->>GitHubAPI: Fetch crafted release notes (TAG = inputs.tag)
  ReleaseJob->>GitHubAPI: Create or update GitHub Release (TAG = inputs.tag)
  GitHubAPI-->>ReleaseJob: Release exists
  ReleaseJob->>GitHubAPI: Upload built assets with clobber
  GitHubAPI-->>Maintainer: Existing release PK-0.9.16 now has assets

Loading

File-Level Changes

Change	Details	Files
Avoid downgrading or reinstalling Inno Setup when it is already present on windows-latest, and fail early with a clear error if the expected ISCC.exe path is missing.	Replace unconditional choco installation of a pinned Inno Setup version with a PowerShell step that checks for ISCC.exe at the expected Program Files(x86) path. Only call choco install innosetup when ISCC.exe is absent, without pinning a specific version. Add an explicit assertion that ISCC.exe exists at the hardcoded path so future runner-image changes surface as a clear failure.	.github/workflows/release.yml
Allow manually dispatched release runs to target an existing tag so built assets are attached to that release, while keeping the ability to run a smoke-test build that only produces artifacts.	Add an optional workflow_dispatch input named tag, with documentation explaining empty vs non-empty behavior. Update the concurrency group expression to include inputs.tag when present so runs for the same tag serialize correctly. Extend the conditions for fetching crafted release notes to run when a tag input is provided. Extend the conditions for creating/updating the GitHub Release to run when a tag input is provided. Update TAG environment variable resolution to prefer github.event.release.tag_name, then inputs.tag, then github.ref_name so all paths share the same tag selection logic.	.github/workflows/release.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.