fix: retrospective review fixes for merged PR #101#116
Merged
Conversation
…ansfer personal org PR #101 fixed .goreleaser.yaml's release.github.owner after the repo moved from ikeikeikeike/bough to threecorp/bough, but missed this commented-out "planned" Homebrew install line in the README, which still names the pre-transfer personal account (ikeikeikeike/tap). No goreleaser `brews:` block exists yet so nothing actually consumes this today, but leaving it as-is would point a future tap implementation (or a user who copy-pastes it early) at the wrong GitHub account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrospective /code-review sweep of merged PR #101 (fix(release): point goreleaser at threecorp/bough after the repo transfer).
What / why
PR #101 correctly fixed
.goreleaser.yaml'srelease.github.ownerfromikeikeikeiketothreecorpafter the repo transfer, and confirmed viagoreleaser check. Verified that fix is still correct and live:release.github.owner: threecorpis the only owner/repo reference in.goreleaser.yaml,goreleaser checkvalidates cleanly,.github/workflows/release.ymlandci.ymlhave no hardcoded org references, and every release run from v0.11.0 (the commit containing PR #101's fix) through the current v0.15.0 tag has completed successfully (gh run list --workflow=release.yml).One stale reference from the same repo-transfer cleanup was missed:
README.md's "planned — tap not yet published" Homebrew install line still named the pre-transfer personal account:No
brews:block exists in.goreleaser.yamlyet, so nothing automated consumes this today — but leaving the personal-account name in place would point a future tap implementation (or anyone who copy-pastes the line early) at the wrong GitHub account, the same class of bug PR #101 fixed in the release config. Updated it tothreecorp/tapfor consistency with the rest of the post-transfer install instructions (go install github.com/threecorp/...via redirect,nix run github:threecorp/bough,/plugin marketplace add threecorp/bough).Test plan
goreleaser check(nix store binary, goreleaser 2.15.4) validates.goreleaser.yamlcleanly — unaffected by this doc-only change, re-confirmed as a baselinegh run list -R threecorp/bough --workflow=release.ymlshows v0.11.0 through v0.15.0 allsuccess, confirming the release pipeline has worked correctly since PR fix(release): point goreleaser at threecorp/bough after the repo transfer #101 merged.md,.yaml,.yml,.json,.nix,.sh) for remainingikeikeikeikereferences outside intentionally-unchanged Go import paths (module github.com/ikeikeikeike/boughstays, per PR fix(release): point goreleaser at threecorp/bough after the repo transfer #101's stated scope, since GitHub's org-transfer redirect keeps it working) — only this README line was a leftover