fix: resolve the three v0.9.18-deferred review items (v0.9.19)#58
Merged
Conversation
No carryover — the deferred review findings are now fixed.
- demotion (H2 residual): narrow the correction-marker set to words that read
as a correction of the assistant (wrong/mistake/incorrect/undo/revert/
broke/broken), dropping the task-dominant error/fix/correct. With v0.9.18's
prompt-scope + whole-word matching, an ordinary task prompt ("fix the bug")
no longer demotes.
- create (#47): renderEnvLocals is best-effort like runPostCreateHooks — a bad
env_local template is recorded + surfaced in the failure summary instead of
aborting before the worktree-path stdout emit (the WorktreeCreate cd
contract) and --strict accounting.
- observer (L4): run-once runs in its own process group (Setpgid); the daemon
kills the whole group on cancel, so a `claude --print` grandchild is reaped
on shutdown instead of orphaning to init.
Tests: session word-boundary cases (task prompts don't demote; "you broke it"
does), renderEnvLocals best-effort + skip/empty, process-group reaps a
grandchild. Full `go test ./...` (incl conformance) + golangci-lint (0) +
gofumpt green.
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the three items I deferred from the v0.9.18 review (#48–#54) — no carryover.
wrong/mistake/incorrect/undo/revert/broke/broken), dropping the task-dominanterror/fix/correct. With v0.9.18's prompt-scope + whole-word matching, a task prompt ("fix the bug") no longer demotes.renderEnvLocalsis best-effort likerunPostCreateHooks— a badenv_localtemplate is recorded + surfaced in the failure summary instead of aborting before the worktree-path stdout emit (the WorktreeCreate cd contract) +--strictaccounting.claude --printgrandchild is reaped on shutdown instead of orphaning to init.Tests: word-boundary cases (task prompts don't demote, "you broke it" does),
renderEnvLocalsbest-effort + skip/empty, process-group reaps a grandchild. Fullgo test ./...(incl conformance) + golangci-lint (0) + gofumpt green.