contd: read environment variable from .stratup.toml if it exists and ensure /etc/resolv.conf #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaibon
requested review from
LeeSmet,
delandtj,
maxux and
muhamadazmy
as code owners
zaibon
force-pushed
the
container_environment
branch
from
3b8866d to
3ee6ecf
Compare
zaibon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
- Coverage 41.59% 39.4% -2.19%
=========================================
Files 54 57 +3
Lines 3284 3522 +238
=========================================
+ Hits 1366 1388 +22
- Misses 1733 1952 +219
+ Partials 185 182 -3
Continue to review full report at Codecov.
|
zaibon
force-pushed
the
container_environment
branch
from
1da0675 to
f6b5b63
Compare
muhamadazmy
requested changes
Oct 14, 2019
zaibon
force-pushed
the
container_environment
branch
from
9c3f5d1 to
94b0fea
Compare
zaibon
force-pushed
the
container_environment
branch
3 times, most recently
from
4fbe91b to
3c555e6
Compare
zaibon
force-pushed
the
container_environment
branch
from
3c555e6 to
e1b8df9
Compare
fixes #319 we extract 3 things from statup.toml: - entrypoint - working dir - enviroment variable
zaibon
force-pushed
the
container_environment
branch
from
e1b8df9 to
1e452ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.