feat(covenantsigner): HTTP issuer for SignerApprovalCertificate - #4235
Open
lionakhnazarov wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lionakhnazarov
force-pushed
the
feat/signer-approval-cert-issuer
branch
2 times, most recently
from
August 7, 2026 09:37
15fe2ac to
43b0f7c
Compare
Operators need a production path to obtain the v2 threshold-signed permission slip that live Submit already requires. Wire the existing issueSignerApprovalCertificate path through POST /v1/admin/signer-approval-certificates on top of threshold-network#4169.
lionakhnazarov
force-pushed
the
feat/signer-approval-cert-issuer
branch
from
August 7, 2026 09:41
43b0f7c to
2cef4b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/admin/signer-approval-certificatesso operators can obtain a real v2SignerApprovalCertificatefor live Submit.issueSignerApprovalCertificate); request bindswalletPublicKeyHash+approvalDigest+endBlock(digest must match the job’s artifact-approval payload).Test plan
go test ./pkg/covenantsigner/ -run 'TestServerIssuesSignerApprovalCertificate|TestServerReturns501|TestServerRequiresBearerTokenForCertificateIssuer|TestServerRejectsUnknownFieldsOnCertificateIssuer|TestServerRejectsInvalidCertificateIssuerInput'go test ./pkg/tbtc/ -run 'TestCovenantSignerEngineIssueSignerApprovalCertificate'0x12b3fd…with a real VBA approval digest → Submit REDEEM → Poll; observe whether other ops join the signing roundMade with Cursor