feat(check-links): exclude docs/reviews/PR-*.md from orphan check (SPEC §6.2) - #145
Merged
Merged
Conversation
Side-effects of running legacy Python logmind v0.6.16 (the only install with a 'log' subcommand) in a repo that's moved to v1.0.0 templates: the older binary downgrades the AGENTS.md block to v5-slim and rewrites docs/timeline.md without the brief auto-collapse. Restore both to match origin/main, with the new decision row included in the brief format. [skip-logmind]
thrillmot
enabled auto-merge (squash)
June 5, 2026 18:52
|
Claude finished @thrillmot's task in 2m 7s —— View job PR #145 Review — feat(check-links): exclude docs/reviews/PR-*.md from orphan checkTasks
No critical issues found. Change is minimal and correct. |
Contributor
🐛 Clud Bug reviewThis round: 0 critical · 0 minor · 0 resolved from prior · 0 still open Found: 0 🔴 / 0 🟡 / 0 🟣 Per-skill scan
Skills referenced: [critical-issues-only, evidence-based-review, respect-existing-conventions] |
thrillmot
added a commit
that referenced
this pull request
Jun 5, 2026
…(G3.b extension v2) (#146) Supersedes #142 (which got tangled in multiple rebase cycles after the §8.6 wave + #145 landed). Same content as #142: removes the legacy per-repo `clud-bug-review.yml` workflow + updates AGENTS.md + .cursorrules to point at the GitHub App. The App (App ID 3944857, scope=all) now reviews PRs — workflow is redundant. This is the **tooling-repo half** of G3.b. Consumer cascade landed earlier today: - thrillmade/agent-skills#117 - thrillmade/clud-bug-app#11 - thrillmade/tokenomics#70 - thrillmade/reporulez#50 - thrillmade/rezgen#26 Remaining: thrillmade/clud-bug#147 (failing on check-links until logmind v1.0.1 patch propagates the docs/reviews/PR-*.md exclude shipped in #145). Co-authored-by: thrillmot <thrillmot@users.noreply.github.com>
2 tasks
thrillmot
added a commit
to thrillmade/clud-bug
that referenced
this pull request
Jun 5, 2026
![clud-bug[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…xclude docs/reviews/) (#149) ## Summary Bumps the logmind install pin in `.github/workflows/check-doc-links.yml` from `v1.0.0` → `v1.0.1` so this repo's CI picks up the orphan-markdown fix shipped in [logmind PR #145](thrillmade/logmind#145). ## Why logmind v1.0.1 (shipped 2026-06-05T20:13Z) carries the structural fix that excludes `docs/reviews/PR-*.md` from the orphan-markdown check. Without this bump, every PR that touches `docs/reviews/` trips the check-links gate — most recently hit on clud-bug#147 and the same false-positive pattern is recurring org-wide on consumers still pinned at v1.0.0. This propagates the fix to clud-bug's CI. Surgical 2-line change: - `curl ... /v1.0.0/installer/install.sh` → `/v1.0.1/installer/install.sh` - Adjacent comment `pinned to v1.0.0 tag` → `pinned to v1.0.1 tag` ## Out of scope Other workflows in this repo (`regen-timeline.yml`, `logmind-self-update.yml`) also pin logmind at v1.0.0. Those are intentionally not touched here — different concern (timeline regen / self-update plumbing, no check-links interaction). Separate PR can sweep them. ## Test plan - [ ] CI green on this PR (check-doc-links job uses the new pin) - [ ] After merge, next PR touching `docs/reviews/PR-*.md` no longer trips check-links 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: thrillmot <thrillmot@users.noreply.github.com> Co-authored-by: clud-bug[bot] <0+clud-bug[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkcheck.DefaultAllowOrphanswithdocs/reviews/(matches the existingdocs/decisions-branches/directory-prefix precedent) sodocs/reviews/PR-<n>.mdreview-writebacks no longer faillogmind check-linksas orphan markdown.internal/linkcheck/linkcheck_test.gocovering the PR-writeback case + the multi-file case (including a hypotheticaldocs/reviews/README.md).Why
clud-bug-appwritesdocs/reviews/PR-<n>.mdper SPEC §6.2 as append-only review telemetry — same fileslogmind syncalready reads ininternal/skill/sync.goto roll citation counts into skillPROVENANCE.md. By design these files are never cross-linked fromREADME.md/AGENTS.md/docs/, so today they tripcheck-links' orphan-markdown rule and fail CI on every PR that picks up a review.This is recurring across every PR org-wide that gets a review. Currently blocking
thrillmade/clud-bug#147. Per principal engineer rec: ship the structural fix here inlogmindrather than the per-repo.logmindignoreroute —logmindhas authoritative knowledge of the SPEC §6.2 path convention (it's the consumer of those files), and a built-in default means every repo onv1.0.x+picks up the fix on the next bump with no per-repo friction.Alternatives considered
.logmindignoreentry: tax replicated across every consumer; logmind already encodes this path viainternal/skill/sync.go.clud-bug-appto stop writing the file: breaks SPEC §6.2 contract; the file is the load-bearing input forlogmind sync.PR-*.md): over-engineers theisAllowedOrphanmechanism (currently exact-match + dir-prefix); the entiredocs/reviews/directory is convention-owned by the App + sync pipeline.Implications
logmind v1.0.x+gets the fix free on next bump.clud-bug#147unblocks; future PRs across the org stop failingcheck-linksfrom review-writebacks.Test plan
go test ./internal/linkcheck/... -race -count=1— all 14 tests pass (12 prior + 2 new).go test ./... -race -count=1— full suite green (no parity regression).logmind check-linkson this repo —All markdown links resolve and no orphans found.Follow-up
Once merged we'll need a
v1.0.xpatch release so consumer repos pick the fix up via brew. Cask-bump is GoReleaser-wired off tag push; that's a separate action.🤖 Generated with Claude Code