feat(decision): publish decision-engine as a reusable library artifact - #186
Merged
Conversation
Apply maven-publish to libs/decision-engine and declare the com.fincore:decision-engine publication from the java component, so the main, sources and javadoc jars ship together with a credible POM (name, description, url, BSL 1.1 license, developers, scm). No remote repository is declared, so the artifact can be consumed locally or in the upcoming standalone repo but nothing can push it remotely; the real release stays an owner action. A library embedding test proves the parser and evaluator are usable through the public api alone, without the decision service. Closes #175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
libs/decision-enginea publishable, embeddable library artifactcom.fincore:decision-engine, usable withoutservices/decision. Appliesmaven-publishand declares one publicationfrom(components["java"])(main + sources + javadoc jars) with a credible POM: name, description, url, BSL 1.1 license, developers, scm.This is the packaging precursor to the standalone-repo extraction (#178).
No remote publish (CLAUDE.md §0)
No
publishing { repositories {} }remote target and no signing are declared, so the build is structurally incapable of pushing the artifact: onlygeneratePomFileForMavenPublication/publishToMavenLocalexist, never apublish...ToRepositorytask. No CI workflow runs a gradle publish. The real release (registry, signing, Maven Central metadata) stays an owner action.Embeddable
LibraryEmbeddingTestproves the public API is self-sufficient: from a JSON rule string + an attribute map, a caller reaches aDecisionResultusing onlycom.fincore.decision.*types (no Spring, no service).Verified (no remote publish involved)
com.fincore:decision-engine:0.1.0-SNAPSHOT, full metadata,<dependencies>= kotlin-stdlib + jackson-databind only (runtime scope), zero Spring/:services:leak.-sources,-javadoc.test/detekt/spotlessCheck/assemblegreen.Gates
critic GO-WITH-CHANGES (AC-4 runtime-scope wording + spotlessApply, folded) -> code-reviewer Needs-Fix resolved (explicit publication version added; 3 LOW Maven-Central items deferred to the owner release slice) -> security-auditor PASS (no secrets, no remote publish, no POM leak, boundary clean) -> evaluator 0.91 PASS.
Closes #175