fix(web): share picker titles match sidebar (name before summary) - #1219
Merged
Conversation
The /share route used a local getSessionTitle that preferred summary.text over metadata.name, so Android share-target rows disagreed with the session sidebar. Reuse @/lib/sessionTitle and lock the precedence with a unit test. Closes tiann#1218 once upstream PR lands after dogfood. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
After-fix — /share picker matches sidebar name (peer stack + operator dogfood yes).
asset: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
- No issues found.
Summary
- Review mode: initial
- Reviewed the full latest diff for
web/src/routes/share/index.tsxandweb/src/lib/sessionTitle.test.ts. No correctness, security, data-loss, performance, or maintainability issues found in the added/modified lines. Residual risk: route-level rendering behavior for the share picker was not exercised here.
Testing
- Not run (automation)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sharepicker used a localgetSessionTitlethat preferredmetadata.summary.textovermetadata.name, so share-target rows disagreed with the session sidebar.@/lib/sessionTitle(name → summary → path → id).Test plan
/sharesummarybun typecheck+ web/hub unit tests:3006/ Android share sheetProof
Before/after PNGs on #1218
Issues
Closes #1218