feat(web): show only authoritative subagent model metadata - #1223
Merged
Conversation
There was a problem hiding this comment.
Review mode: initial
No issues found in the diff.
Residual risk: I could not run bun test here because bun is not installed in this environment. The new helper coverage exercises the fallback path, but there is still no rendered-component test for the badge in ToolCard/ToolMessage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1221
Root cause
The existing subagent model badge only inspects model-bearing child blocks. That is sufficient for Claude sidechains, but Codex app-server collaboration events already preserve an authoritative explicit per-invocation model in the spawn tool input and may not expose child blocks in the parent trace.
Change
modelonly when no executed child model is available.Impact
Codex and any other backend that explicitly reports the subagent invocation model now show it in the existing badge. No inferred model is displayed.
Validation
bun typecheckbun run test— CLI 1527, hub 643, web 1562, shared 142 tests passedgit diff --checkbun run build:webAI disclosure
Investigated and implemented with OpenAI Codex under human direction.