Skip to content

fix(web): align compact dialog titles - #1253

Merged
heavygee merged 1 commit into
tiann:mainfrom
techotaku39:fix/web-session-action-dialog-title-alignment
Jul 31, 2026
Merged

fix(web): align compact dialog titles#1253
heavygee merged 1 commit into
tiann:mainfrom
techotaku39:fix/web-session-action-dialog-title-alignment

Conversation

@techotaku39

Copy link
Copy Markdown
Contributor

Summary

Center titles in compact action and confirmation dialogs, and align the first title line with the close button's horizontal centerline.

Content-heavy dialogs with long or dynamic titles remain left-aligned.

Changes

  • Add an opt-in centered-title layout to the shared confirmation dialog.
  • Apply it to session archive, delete, and reopen-error dialogs, plus the duplicate-session merge confirmation.
  • Use the same layout for rename-session, export-conversation, and external-link confirmation dialogs.
  • Reserve symmetric space around centered titles so they remain visually centered without overlapping the close action.
  • Use a 24px minimum title row and line height so longer translations can wrap safely on narrow screens.
  • Add regression coverage for the centered layout and the unchanged default confirmation-dialog layout.

Testing

  • bun run typecheck
  • bun run test:web
  • bun run build:web
  • git diff --check
  • Manual verification using the port 3016 test deployment

AI disclosure

Code and tests were prepared with OpenAI GPT-5.6-sol (Codex).

@techotaku39
techotaku39 marked this pull request as draft July 31, 2026 02:06
@techotaku39
techotaku39 marked this pull request as ready for review July 31, 2026 02:06

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No Blocker, Major, Minor, or Nit findings in the added or modified lines.

Questions

  • None.

Summary

  • Review mode: initial. Full latest diff reviewed; no correctness, security, regression, data-loss, performance, or maintainability issue found at or above the 80% confidence threshold. Residual risk: the new tests assert layout classes but do not verify rendered geometry when titles wrap on narrow screens.

Testing

  • Not run (automation; PR content was not executed during review). The GitHub test check reports pass. Existing added coverage checks centered and default class application; narrow-screen browser geometry remains a manual testing gap.

HAPI Bot

@techotaku39
techotaku39 force-pushed the fix/web-session-action-dialog-title-alignment branch from fc0c693 to 4c01537 Compare July 31, 2026 02:46

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No Blocker, Major, Minor, or Nit findings in the added or modified lines.

Questions

  • None.

Summary

  • Review mode: follow-up after new commits. Full latest diff reviewed; no correctness, security, regression, data-loss, performance, or maintainability issue found at or above the 80% confidence threshold. The current head has the same Git tree and parent as the previously reviewed commit, so the SHA update introduced no content change. Residual risk: the layout tests assert Tailwind classes but do not verify rendered geometry for wrapped titles at narrow viewport widths.

Testing

  • Not run (automation; PR content was not executed during review). The workflow test check was still in progress when inspected. Existing coverage checks centered/default class application; narrow-screen browser geometry remains a manual testing gap.

HAPI Bot

@heavygee
heavygee force-pushed the fix/web-session-action-dialog-title-alignment branch from 4c01537 to 09fa062 Compare July 31, 2026 14:03

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No Blocker, Major, Minor, or Nit findings in the added or modified lines.

Questions

  • None.

Summary

  • Review mode: follow-up after new commits. Full latest diff reviewed; no correctness, security, regression, data-loss, performance, or maintainability issue found at or above the 80% confidence threshold. The head was rebased onto a newer main; the feature patch remains equivalent, with the duplicate-session confirmation call relocated from web/src/router.tsx to web/src/components/NewSession/index.tsx alongside the upstream refactor. Residual risk: the unit tests verify Tailwind class composition, but rendered geometry for wrapped translations at narrow viewport widths remains covered only by manual verification.

Testing

  • Not run (automation; PR content was not executed during review). Existing tests cover the centered opt-in and unchanged default class layout; narrow-screen browser geometry remains a testing gap.

HAPI Bot

@heavygee heavygee added the low-impact Focused / low-blast-radius change; estate lane B promote candidate (PR merge policy) label Jul 31, 2026
@heavygee
heavygee merged commit 39da5c4 into tiann:main Jul 31, 2026
2 checks passed
heavygee added a commit to heavygee/hapi that referenced this pull request Jul 31, 2026
Emoji batch missed that phrasing (no literal "No findings"), so green
PRs like tiann#1253 got sticky ⚠️ "address latest bot review". Align
hapi-pr-status and drop bare "- None." which matched Questions (tiann#1108).

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-impact Focused / low-blast-radius change; estate lane B promote candidate (PR merge policy)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants