fix(web): align compact dialog titles - #1253
Merged
heavygee merged 1 commit intoJul 31, 2026
Merged
Conversation
techotaku39
marked this pull request as draft
July 31, 2026 02:06
techotaku39
marked this pull request as ready for review
July 31, 2026 02:06
There was a problem hiding this comment.
Findings
- No Blocker, Major, Minor, or Nit findings in the added or modified lines.
Questions
- None.
Summary
- Review mode: initial. Full latest diff reviewed; no correctness, security, regression, data-loss, performance, or maintainability issue found at or above the 80% confidence threshold. Residual risk: the new tests assert layout classes but do not verify rendered geometry when titles wrap on narrow screens.
Testing
- Not run (automation; PR content was not executed during review). The GitHub test check reports pass. Existing added coverage checks centered and default class application; narrow-screen browser geometry remains a manual testing gap.
HAPI Bot
techotaku39
force-pushed
the
fix/web-session-action-dialog-title-alignment
branch
from
July 31, 2026 02:46
fc0c693 to
4c01537
Compare
There was a problem hiding this comment.
Findings
- No Blocker, Major, Minor, or Nit findings in the added or modified lines.
Questions
- None.
Summary
- Review mode: follow-up after new commits. Full latest diff reviewed; no correctness, security, regression, data-loss, performance, or maintainability issue found at or above the 80% confidence threshold. The current head has the same Git tree and parent as the previously reviewed commit, so the SHA update introduced no content change. Residual risk: the layout tests assert Tailwind classes but do not verify rendered geometry for wrapped titles at narrow viewport widths.
Testing
- Not run (automation; PR content was not executed during review). The workflow test check was still in progress when inspected. Existing coverage checks centered/default class application; narrow-screen browser geometry remains a manual testing gap.
HAPI Bot
heavygee
force-pushed
the
fix/web-session-action-dialog-title-alignment
branch
from
July 31, 2026 14:03
4c01537 to
09fa062
Compare
There was a problem hiding this comment.
Findings
- No Blocker, Major, Minor, or Nit findings in the added or modified lines.
Questions
- None.
Summary
- Review mode: follow-up after new commits. Full latest diff reviewed; no correctness, security, regression, data-loss, performance, or maintainability issue found at or above the 80% confidence threshold. The head was rebased onto a newer main; the feature patch remains equivalent, with the duplicate-session confirmation call relocated from web/src/router.tsx to web/src/components/NewSession/index.tsx alongside the upstream refactor. Residual risk: the unit tests verify Tailwind class composition, but rendered geometry for wrapped translations at narrow viewport widths remains covered only by manual verification.
Testing
- Not run (automation; PR content was not executed during review). Existing tests cover the centered opt-in and unchanged default class layout; narrow-screen browser geometry remains a testing gap.
HAPI Bot
heavygee
added a commit
to heavygee/hapi
that referenced
this pull request
Jul 31, 2026
Emoji batch missed that phrasing (no literal "No findings"), so green PRs like tiann#1253 got sticky⚠️ "address latest bot review". Align hapi-pr-status and drop bare "- None." which matched Questions (tiann#1108). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Center titles in compact action and confirmation dialogs, and align the first title line with the close button's horizontal centerline.
Content-heavy dialogs with long or dynamic titles remain left-aligned.
Changes
Testing
bun run typecheckbun run test:webbun run build:webgit diff --checkAI disclosure
Code and tests were prepared with OpenAI GPT-5.6-sol (Codex).