fix(web): keep line numbers clear when code wraps - #1260
Merged
Conversation
junmo-kim
force-pushed
the
fix/terminal-wrap-fidelity
branch
from
July 30, 2026 23:16
6a16798 to
d7a05c1
Compare
junmo-kim
marked this pull request as ready for review
July 30, 2026 23:56
There was a problem hiding this comment.
Findings
- [Minor] Browser geometry regression is not gated by CI — the added Playwright test verifies the actual gutter separation and mobile wrapping, but the PR workflow only runs typecheck and unit tests; it never invokes
test:e2e. Evidence:e2e/terminal-wrap-fidelity.spec.ts:8,.github/workflows/test.yml:16,.github/workflows/test.yml:26
Suggested fix:- run: bunx playwright install --with-deps chromium - run: bun run test:e2e -- terminal-wrap-fidelity.spec.ts
Questions
- None.
Summary
- Review mode: initial
- One Minor testing gap found. No Blocker/Major correctness, security, data-loss, or performance issue found in the changed lines. Residual risk: the mobile browser geometry asserted by the new spec is not enforced by current PR CI.
Testing
- Not run (automation). The live GitHub
testcheck passed, but that workflow does not run Playwright.
HAPI Bot
There was a problem hiding this comment.
Findings
- None.
Questions
- None.
Summary
- Review mode: follow-up after new commits
- No Blocker, Major, Minor, or Nit findings in the latest full diff. The prior browser-CI coverage gap is resolved by
.github/workflows/test.yml:17-18. Residual risk: the browser geometry assertion is environment-sensitive and depends on the new Playwright CI step remaining stable.
Testing
- Not run (automation). Reviewed the current workflow and test coverage statically; live GitHub checks were consulted before submission.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The global code-wrap support I added in #985 introduced this regression. I sized the gray line-number gutter from the number of digits alone and missed the cell's horizontal padding, so narrow wrapped output can leave line numbers crowded against or overlapping the code column.
Diff views already consume the global code-wrap preference but do not expose the wrap control themselves, so changing the setting requires finding a separate code block.
Solution
Before / After
Before, the gutter track reserves only the digit width. After, it reserves the digit width plus both padded sides, so the number and code columns remain visually separate at every line-count boundary.
Tests
bun run typecheckbun run testbun run build:webnumberRight < codeTextLeft