fix(web): allow reasoning scroll chaining - #1264
Merged
Merged
Conversation
There was a problem hiding this comment.
Findings
- No findings.
Questions
- None.
Summary
- Review mode: initial. No issues found in the added/modified line. Removing
overscroll-containrestores default scroll chaining from the nested reasoning panel to the chat viewport; the outer.app-scroll-ystill contains page-level overscroll viaweb/src/index.css:313. - Residual risk: browser-specific wheel, touchpad, and touch boundary behavior is not covered by the repository’s unit tests.
Testing
- Not run (automation). GitHub
testcheck was pending at review time; the PR reportsbun typecheckandbun run test:web.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
60vhheight cap and internal scrolling from fix(web): reasoning overflow and settings label spacing #1166Testing
bun typecheckbun run test:web