test(cursor): isolate cursor-models shared-cache tests to stop parallel-run flake

[heavygee]

Summary

Fixes a flaky failure in the CLI test suite:

cursorModels.test.ts > buildCursorModelsSeedPayload > inherits cliModelSkus from shared cache when ACP snapshot has none
AssertionError: expected undefined to deeply equal [ 'gpt-5.5-medium', 'gpt-5.5-high' ]

The four cursorModels* test files share one on-disk cache path ($HAPI_HOME/cache/cursor-models.json, defaulting to /tmp/hapi when HAPI_HOME is unset). Two of them already isolate it - cursorModelsStaleLock.test.ts (PID-namespaced home) and handlers/cursorModels.test.ts (unique temp home with save/restore) - but cursorModels.test.ts and cursorModelsSharedCache.test.ts do not.

Under vitest's parallel file execution, cursorModelsSharedCache's afterEach(_resetSharedCursorModelsCacheForTests) rmSyncs that shared file between the other file's write and read, so the read returns null and cliModelSkus is undefined. It passes in isolation and fails at random in the full parallel suite.

Root cause (deterministic proof)

Both un-isolated files resolve to the same path with HAPI_HOME unset; one file's reset deletes the other's write:

after A write, read.cliModelSkus = [ 'gpt-5.5-medium', 'gpt-5.5-high' ]
after B reset (rmSync same path), A reads = null   => cliModelSkus undefined

Parallel scheduling just decides whether B's reset lands inside A's write->read window.

Fix

Give the two un-isolated files their own mkdtemp HAPI_HOME at module load, matching the pattern the other two already use. mkdtempSync guarantees a unique dir regardless of worker-process reuse, so no two files collide.

Post-fix, the same interleaving leaves A's write intact:

A reads after B reset = [ 'gpt-5.5-medium', 'gpt-5.5-high' ]   => intact

Test-isolation only; no product/behavior change (source cursorModelsSharedCache.ts is untouched).

Test plan

• bun typecheck clean (cli + web + hub)
• Full cli suite: cursorModels* green across 2 runs + 25 targeted parallel runs of all four cache files
• Deterministic pre/post interleaving proof (above)
• Diff is exactly the two test files

Note: the pre-existing 1-minute runner.integration.test.ts > should detect version mismatch and kill old runner failure is environment-dependent and unrelated to this change (no runner code touched).

[github-actions]

Findings

• [Minor] Clean up each per-file temporary HAPI home — both new mkdtempSync calls create roots outside the suite-managed tmpHome, while the added files only remove the cache file. The global teardown removes only its own tmpHome, so every run leaves these directories behind. Save/restore HAPI_HOME and recursively remove each per-file root in afterAll. Evidence: cli/src/modules/common/cursorModels.test.ts:10, cli/src/modules/common/cursorModelsSharedCache.test.ts:14.

  Suggested fix:

  import { afterAll, afterEach, describe, expect, test } from "vitest"
  import { mkdtempSync, rmSync } from "node:fs"
  
  const previousHapiHome = process.env.HAPI_HOME
  const testHapiHome = mkdtempSync(join(tmpdir(), "hapi-cursor-models-"))
  process.env.HAPI_HOME = testHapiHome
  
  afterAll(() => {
      if (previousHapiHome === undefined) delete process.env.HAPI_HOME
      else process.env.HAPI_HOME = previousHapiHome
      rmSync(testHapiHome, { recursive: true, force: true })
  })

Summary

Review mode: initial. One minor test-isolation cleanup issue found.

Testing

Not run (automation); repository CI test check was pending at review time.

HAPI Bot

[github-actions]

[MINOR] Remove the per-file temp home after the suite

mkdtempSync creates a new root on every run, but afterEach only removes cache/cursor-models.json; the global teardown removes only the separate suite tmpHome. This root therefore remains in the system temp directory. The same issue exists at cli/src/modules/common/cursorModelsSharedCache.test.ts:14.

Suggested fix:

const previousHapiHome = process.env.HAPI_HOME
const testHapiHome = mkdtempSync(join(tmpdir(), "hapi-cursor-models-"))
process.env.HAPI_HOME = testHapiHome

afterAll(() => {
    if (previousHapiHome === undefined) delete process.env.HAPI_HOME
    else process.env.HAPI_HOME = previousHapiHome
    rmSync(testHapiHome, { recursive: true, force: true })
})

[heavygee]

Hey @tiann - went ahead and merged this one myself: trivial test-only isolation fix (2 test files, +16 lines, zero source/runtime change). Thinking I could take low-impact PRs like this off your plate so only the meatier stuff needs your eyes - that work for you? Tell me if this is me 越俎代庖 and I'll happily back off.

[tiann]

Sounds great! Thanks for helping out.

…

On Fri, 31 Jul 2026 at 17:43, HeavyGee ***@***.***> wrote: *heavygee* left a comment (tiann/hapi#1268) <#1268 (comment)> Hey @tiann <https://github.com/tiann> - went ahead and merged this one myself: trivial test-only isolation fix (2 test files, +16 lines, zero source/runtime change). Thinking I could take low-impact PRs like this off your plate so only the meatier stuff needs your eyes - that work for you? Tell me if this is me 越俎代庖 and I'll happily back off. — Reply to this email directly, view it on GitHub <#1268?email_source=notifications&email_token=ABAJUEFYNMP4UTDBJKHLAF35HRS4JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUGE2TGOBTGQ2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5141538344>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAJUEBMWXV775KC3I677OD5HRS4JAVCNFSNUABGKJSXA33TNF2G64TZHMYTCMRSGI2DEMJSGE5US43TOVSTWNJQGI4DEOBTGA3TFILWAI> . You are receiving this because you were mentioned.Message ID: ***@***.***>