Skip to content

fix(web): align browse button and select chevrons - #1279

Merged
tiann merged 2 commits into
tiann:mainfrom
techotaku39:fix/web-create-session-directory-layout
Aug 1, 2026
Merged

fix(web): align browse button and select chevrons#1279
tiann merged 2 commits into
tiann:mainfrom
techotaku39:fix/web-create-session-directory-layout

Conversation

@techotaku39

Copy link
Copy Markdown
Contributor

Summary

  • Stretch the New Session Browse button to match the adjacent directory input height.
  • Add a shared SelectControl with an inset chevron and reserved right-side text space while preserving native select behavior.
  • Use the shared control for all web selects so the indicator spacing stays consistent across New Session, Workspace Browser, Codex session sync, and voice settings.

Problem

The New Session directory row rendered the Browse button shorter than the directory input. Native select indicators were also positioned by the browser and sat too close to the right edge, including the other selects on the same page and elsewhere in the web app.

Testing

  • bun typecheck
  • bun run test:web (197 files, 1,717 tests)
  • bun run test:shared (152 tests)
  • bun run build
  • Manual smoke test on the mobile New Session layout via the local production build

AI disclosure

This change was implemented and reviewed with OpenAI Codex.

@techotaku39
techotaku39 marked this pull request as draft August 1, 2026 14:34
@techotaku39
techotaku39 marked this pull request as ready for review August 1, 2026 14:34

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No findings.

Summary
Review mode: initial
No issues found in the added or modified lines. Residual risk is limited to browser-specific native select rendering and responsive visual alignment; the PR includes component/unit coverage, while repository CI passed.

Testing

  • Not run locally (automation); the repository test check passed for the reviewed head.

HAPI Bot

@techotaku39
techotaku39 force-pushed the fix/web-create-session-directory-layout branch from d3b50a8 to 36a0e5b Compare August 1, 2026 14:47

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No findings.

Summary
Review mode: follow-up after new commits
No issues found in the added or modified lines. Residual risk remains browser-specific select rendering and responsive visual alignment: the added tests verify classes, wrapper sizing, and native change behavior, but not actual rendering in mobile/desktop browsers.

Testing

  • Not run (automation); the repository test check was still in progress at review time.

HAPI Bot

@tiann
tiann merged commit 6aae444 into tiann:main Aug 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants