fix(pi): expose native skills through $ instead of / - #1286
Merged
Conversation
There was a problem hiding this comment.
Findings
- No issues found in the added or modified lines.
Questions
- None.
Summary
- Review mode: initial. No Blocker, Major, Minor, or Nit findings. Residual risk: the Pi namespace and prompt rewrite are covered by helper tests, but not by an end-to-end test against a real Pi RPC process.
Testing
- Not run (automation): Bun is unavailable in this review environment; the GitHub test check was pending at review time.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_commandsinventory by native source: skills go to HAPI$, prompt/extension commands stay in/skill:<name>transport prefix to$<name>and translate HAPI invocations back to/skill:<name>Pi RPC documents
source: "skill"entries as/skill:<name>commands and expands them for prompt/steer input. Gemini legacy is intentionally out of scope.Fixes #1285
Parent: #1284
Verification
bun typecheck— exit 0bun run test— 4,243 passed; 3 skipped; 0 failed