feat(cli): follow conversation language in status summaries - #1584
Merged
tiann merged 1 commit intoAug 16, 2026
Conversation
There was a problem hiding this comment.
Findings
- No findings.
Summary
Review mode: initial
No correctness, security, regression, data-loss, performance, or maintainability issue was found in the changed lines. Residual risk: language selection remains model-dependent; the added tests validate the static prompt and exact footer contract, but not emitted summaries across each supported agent flavor.
Testing
- Not run (automation); executing code from PR content is disallowed by the review security policy. Static inspection completed; git diff --check passed.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_NOTIFY_SUMMARYinstruction to use the language used by the user in the current conversation for human-readableactionandsummaryvalues.Problem / Motivation
The status-summary instruction is written in English, so agents may produce English human-readable values even when the user is communicating in Chinese or another language.
For this use case, prompt guidance based on the current conversation is sufficient and avoids the additional state, synchronization, and API surface required by a UI-locale-based implementation.
Compatibility / Risk
AGENT_NOTIFY_SUMMARYparser contract is unchanged.Validation
bunx vitest run src/modules/common/sessionSummaryInstruction.test.tsfromcli/— 9 passed.bun run typecheck:cli— passed.pwsh -NoProfile -File .\scripts\Invoke-HapiTaskPlaywright.ps1 -Name notify-summary-prompt-language -Suite Root -TestArgs terminal-wrap-fidelity.spec.ts— 2 passed.bun run test:web— 259 files / 2,474 tests passed.bun run test:shared— 262 tests passed.bun run build— passed.git diff --check— passed.Related Issues
Refs #1532
Related PRs
Supersedes #1548
AI Assistance
AI-assisted with OpenAI Codex using GPT-5.6.