feat(web): configure session preview limit#629
Merged
Conversation
There was a problem hiding this comment.
Findings
No issues found in the added or modified lines.
Summary
Review mode: initial
Reviewed the full PR diff for the configurable session preview limit, including the new storage hook, settings UI, locale strings, and SessionList folding integration. Residual risk: I could not execute the web test/typecheck suite in this runner because bun is not installed.
Testing
Not run (automation: bun unavailable in runner).
HAPI Bot
junmo-kim
added a commit
to junmo-kim/hapi
that referenced
this pull request
May 17, 2026
Rebase onto upstream/main (c5e80e9) replayed the UriConfirmDialog commit (2f933b7) which originally modified en.ts and zh-CN.ts from the old base (60af983). Three upstream-added i18n keys that were introduced after the old base were absent from our rebased commit: - sessions.group.new (from tiann#627 preview linked session files) - file.page.imagePreviewAlt (from tiann#627) - settings.display.sessionPreviewLimit{,.decrease,.increase} (from tiann#629) Restore all 5 keys in both en.ts and zh-CN.ts so upstream features (directory new-session action, file image preview, session preview limit setting) remain fully functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan