fix(web): preserve session preview folding#666
Merged
Conversation
There was a problem hiding this comment.
Findings
- No issues found.
Summary
- Review mode: initial
- Full diff reviewed:
web/src/components/SessionList.tsxandweb/src/components/SessionList.test.ts. - Residual risk: validation is helper-level only; no rendered session-list interaction test covers selected-session visibility while preview folding remains collapsed.
Testing
- Not run (automation; PR content not executed during review).
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why #629 was not enough
This follows up on #629, which added the configurable “Sessions Before Folding” / session preview limit. That setting was applied in the basic folded-preview path, but two later/default visibility rules could effectively bypass it:
This PR keeps the useful auto-expansion of the containing machine/project, but preserves session preview folding. It also narrows the required-visible exception to pending-request sessions and the selected session.
Test plan
bun test web/src/components/SessionList.test.tsbun run typecheck:web