fix(web): keep abort next to Send by default - #988
Merged
Conversation
Abort's position shifted with conditional siblings (terminal/switch/ schedule), making the destructive action's location unpredictable. Move it to the last child of the left button group so it's always immediately left of Send — pure JSX reorder, no markup/props/handler changes.
Keep the product default predictable without changing saved custom order or the registry used to append missing items.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
No findings.
Questions
None.
Summary
Review mode: follow-up after new commits
No issues found in the latest diff. Residual risk: this review did not execute PR code; UI render behavior depends on the existing toolbar-layout consumer and persisted custom layouts remain intentionally unchanged.
Testing
Not run (automation; PR code not executed)
HAPI Bot
junmo-kim
changed the title
Contributor
Author
|
Updated this to work with the recently merged customizable toolbar. Abort ended up in the middle of the default toolbar when I added Scheduled in #590. Since it is only relevant while a turn is running, keeping it next to Send makes the default action area more predictable; saved custom layouts remain untouched. |
swear01
added a commit
to swear01/hapi
that referenced
this pull request
Jul 29, 2026
heavygee
added
the
low-impact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composer toolbar is customizable, but defaults still matter. Asking each user to manually reposition Abort for a predictable layout shifts a basic UX decision onto them.
Abort is a transient control used while a turn is running, so the default now keeps it at the end of the toolbar, immediately next to Send. Saved custom orders remain unchanged.
Change
Before / After
The red callout is added only to make the Abort position easy to compare.
Test plan
bun typecheckbun run test