Skip to content

fix(embedding): pin onnxruntime-node for Intel Mac nested installs - #198

Merged
tickernelz merged 3 commits into
tickernelz:mainfrom
EyJunge1:fix/intel-mac-onnxruntime-direct-dep
Jul 30, 2026
Merged

fix(embedding): pin onnxruntime-node for Intel Mac nested installs#198
tickernelz merged 3 commits into
tickernelz:mainfrom
EyJunge1:fix/intel-mac-onnxruntime-direct-dep

Conversation

@EyJunge1

@EyJunge1 EyJunge1 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • bun test tests/onnxruntime-resolve.test.ts tests/package-dependencies.test.ts (7 pass)
  • On Intel Mac, clear ~/.cache/opencode/packages/opencode-mem@* and reinstall the plugin (needs real darwin/x64 hardware; not verified here)
  • Confirm local embedding warmup succeeds with onnxruntime-node@1.22.0 (needs real darwin/x64 hardware; not verified here)
  • Confirm a missing x64 binding fails fast with a remote-embedding hint instead of leaving memory stuck initializing (covered by intel mac missing-binding message mentions remote embedding fallback + getEmbeddingInitError() path)

…ickernelz#184)

Make onnxruntime-node@1.22.0 a direct dependency and resolve-shim it before
loading transformers, so OpenCode's nested plugin install (which ignores
package overrides) still gets a darwin/x64 binding. Fail fast with a clear
remote-embedding hint instead of leaving memory stuck initializing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@EyJunge1
EyJunge1 force-pushed the fix/intel-mac-onnxruntime-direct-dep branch from 14dad72 to 258238c Compare July 28, 2026 12:46
EyJunge1 and others added 2 commits July 28, 2026 14:49
Keep existing runtime mocks and compatible client implementations working while still surfacing native embedding initialization failures when supported.

Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the retired macOS 13 label so the Intel embedding verification can run instead of remaining queued indefinitely.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tickernelz
tickernelz merged commit 1e40183 into tickernelz:main Jul 30, 2026
9 checks passed
@tickernelz

Copy link
Copy Markdown
Owner

Merged into main as part of the newest-to-oldest integration batch and scheduled for the v2.22.0 release.

The combined four-PR tree was verified with:

  • bun install --frozen-lockfile
  • cd web && bun install --frozen-lockfile
  • bun run typecheck
  • bun run build (including the React/Vite production bundle)
  • bun test287 passed / 0 failed / 631 assertions
  • git diff --check

The pushed main tree exactly matches the locally tested synthetic merge tree.

@tickernelz

Copy link
Copy Markdown
Owner

Released in v2.22.0. The npm registry artifact was downloaded, checksum-verified, installed with lifecycle scripts disabled, and passed native dependency, libSQL vector, package entrypoint, and bundled web UI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Intel Mac still broken on v2.20.0: onnxruntime override is ignored in OpenCode's nested install

2 participants