Require explicit Filesystem selection - #25
Merged
Conversation
Icemap
marked this pull request as ready for review
July 27, 2026 08:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set-default-file-system,unset-default-file-system, and--set-defaultinterfaces--file-system-nameorTDC_FS_FILE_SYSTEM_NAME, without registry-cardinality fallbackWhy
A saved or inferred default can silently redirect an agent operation when resources are added or deleted. Explicit process-level selection makes the target deterministic while still allowing repeated commands to use
TDC_FS_FILE_SYSTEM_NAME.Control-plane create, describe, and delete commands continue to require the flag itself. Data-plane, mount, Git, Journal, and Vault commands accept either the flag or environment selector. List-all and mount-locator cleanup commands do not require an FS selector.
Compatibility
Existing per-resource registry credentials remain unchanged. The obsolete
fs_default_file_system_namekey is never used for selection and is removed through the existing local migration path. No backend, Drive9 CLI, CGO, or third-party dependency change is required.The corresponding public documentation update is in pingcap/docs#23306.
Validation
make testmake e2eTDC_LIVE_FS_NAME=tdc-token-manual-20260725114849 make live-e2e-fsTDC_LIVE_FS_NAME=tdc-token-manual-20260725114849 make live-e2e-fs-gitTDC_LIVE_FS_NAME=tdc-token-manual-20260725114849 make live-e2e-fs-journalTDC_LIVE_FS_NAME=tdc-token-manual-20260725114849 make live-e2e-fs-vaultTDC_LIVE_FS_NAME=tdc-token-manual-20260725114849 make live-e2egit diff --check