New app: Zenhub - #690
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Included MD5 hash of user's api key in the cache key, per comments in other PRs |
matslina
left a comment
matslina
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR!
I've added a few comments in the code, and of course the build is failing but that should be a simple fix I think. When we get it merged, feel free to ping me on discord and I'll get you set up with beta access so you can test it out in production before we publish it. I miiiight set up my own Zenhub account for testing, but maybe not. =)
| selected_labels = config.str("selected_labels", "") | ||
| selected_assignees = config.str("selected_assignees", "") | ||
|
|
||
| if not zenhub_rest_api_key: |
There was a problem hiding this comment.
Would be great if the app could display an illustrative default graphic when no config is provided. That lets users get a sense of what the app is all about, before they decide to figure out how to grab API keys and such.
There was a problem hiding this comment.
Hey, Mats! Thanks for the review. Nice suggestion, I added a welcome page with fake tasks guiding the user to set-up the configuration info, like below:
welcome_screen.mov
| Name: "Zenhub", | ||
| Author: "thiagobrez", | ||
| Summary: "Show Zenhub issues", | ||
| Desc: "Show Zenhub issues from a Pipeline of your choice. Filter by labels and assignees.", |
There was a problem hiding this comment.
The description fields in get_schema adds a ton of useful context. Unfortunately, these aren't visible to the user in the current Tidbyt iOS/Android app. It would be great if the app description itself could be expanded so users get a good idea of how to set the app up.
There was a problem hiding this comment.
Yeah, I imagined this could be a thing. I moved the guides to the description, see if that works!
|
Fixed the build and the other requested changes. Let me know what you think! |
|
Looks great, thank you! |
3 participants
Integrate your Zenhub workspace to the Tidbyt display.
Zenhub is a productivity management tool to keep track of issues and features like Jira, Asana, Azure DevOps. Using your Zenhub API Keys, we can pull information from your workspace and show in your Tidbyt display.