dials for threshold structure and parallel regression assumption arguments#462
Open
corybrunson wants to merge 2 commits into
Open
dials for threshold structure and parallel regression assumption arguments#462corybrunson wants to merge 2 commits into
corybrunson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces dials for tuning two proposed new
ordinal_regmodel parameters; see this parsnip PR. Both are specific to ordinal regression.threshold_structurecontrols the constraints on the cut-points between the response value ranges for ordinal regression. It is categorical and takes 4 values, corresponding to specifications shared (under different conventions) by theclmandvglmengines in ordered. (ordered provides an additional option forvglm.) Other than"flexible"(the usual default), it removes one degree of freedom from the model.parallel_regcontrols whether the parallel regression assumption is imposed on the predictors. While the proposed model argument is quite flexible, the dial is logical; it only supports imposing the assumption on (a) all or (b) no predictors. These are the only two options supported by all three engines that accept the model argument:clm,vglm, andordinalNet.As mentioned in the parsnip PR, i'm very open to critical feedback, including on whether these dials are warranted in the first place. I designed them with a brms engine also in mind—the package supports user control over both behaviors—though i since learned that there is some uncertainty over whether it would be appropriate (see the parsnip PR).