-
Notifications
You must be signed in to change notification settings - Fork 83
Develop -> master #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop -> master #140
Conversation
Observed stat
…into observed-stat
Observed stat
Thanks, @jimrothstein! Looks good.
|
@andrewpbray We'll need to make sure to remember to remove the okcupid vignettes whenever we merge into |
andrewpbray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- Desc file currently suggests the okcupiddata package. Can this be stripped out?
- Looks like there's lots of html in here. Was pkgdown run?
|
Yes and yes. See above for okcupiddata. We just need to remove those vignettes prior to merging. |
|
I don’t have travis set up to run on other branches so infer-dev.netlify.com needs pkgdown to be built. |
|
@andrewpbray I have removed the docs folder that pkgdown created and okcupiddata from DESCRIPTION. Note that the removal of the docs folder will cause netlify to fail deployment to infer-dev.netlify.com as can be seen below. This shouldn't affect the deployment to infer.netlify.com though. I have merged the Based on the comments you left, I'm assuming everything else is OK? If so, will you be able to merge to |
Adding p_value(), conf_int(), and corresponding aliases with improved `visualize()`
|
I'll get the submit train started. Hopefully no hiccups =) |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
@andrewpbray We might as well add in the observed statistic and auto
typecreation stuff to the next CRAN release. I've bumped the version to 0.2.1.