Skip to content

Conversation

@ismayc
Copy link
Collaborator

@ismayc ismayc commented May 13, 2018

@andrewpbray We might as well add in the observed statistic and auto type creation stuff to the next CRAN release. I've bumped the version to 0.2.1.

@ismayc
Copy link
Collaborator Author

ismayc commented Jul 6, 2018

@andrewpbray We'll need to make sure to remember to remove the okcupid vignettes whenever we merge into master. Hopefully, I'll get those all methods implemented at some point and then we won't need to remember that caveat.

Copy link
Collaborator

@andrewpbray andrewpbray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. Desc file currently suggests the okcupiddata package. Can this be stripped out?
  2. Looks like there's lots of html in here. Was pkgdown run?

@ismayc
Copy link
Collaborator Author

ismayc commented Jul 6, 2018

Yes and yes. See above for okcupiddata. We just need to remove those vignettes prior to merging.

@ismayc
Copy link
Collaborator Author

ismayc commented Jul 6, 2018

I don’t have travis set up to run on other branches so infer-dev.netlify.com needs pkgdown to be built.

@ismayc
Copy link
Collaborator Author

ismayc commented Jul 7, 2018

@andrewpbray I have removed the docs folder that pkgdown created and okcupiddata from DESCRIPTION. Note that the removal of the docs folder will cause netlify to fail deployment to infer-dev.netlify.com as can be seen below. This shouldn't affect the deployment to infer.netlify.com though. I have merged the p_value branch into develop so you can do a full review of this PR into master.

Based on the comments you left, I'm assuming everything else is OK? If so, will you be able to merge to master and get this sent to CRAN this weekend? I'd love to keep us close to the release schedule at #139. I can also go through the devtools::release() steps from RStudio and all you'll need to do is click the link from the email if you merge to master. Just keep me posted.

ismayc and others added 3 commits July 6, 2018 18:33
Adding p_value(), conf_int(), and corresponding aliases with improved `visualize()`
@andrewpbray andrewpbray merged commit ee1b621 into master Jul 8, 2018
@andrewpbray
Copy link
Collaborator

I'll get the submit train started. Hopefully no hiccups =)

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants