Skip to content

Conversation

@ismayc
Copy link
Collaborator

@ismayc ismayc commented Jun 14, 2018

Compare the NEWS on this branch here to what is on develop here for changes

@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #144 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #144    +/-   ##
=======================================
  Coverage      100%   100%            
=======================================
  Files           10     12     +2     
  Lines          972   1104   +132     
=======================================
+ Hits           972   1104   +132
Impacted Files Coverage Δ
R/hypothesize.R 100% <ø> (ø) ⬆️
R/conf_int.R 100% <100%> (ø)
R/wrappers.R 100% <100%> (ø) ⬆️
R/p_value.R 100% <100%> (ø)
R/calculate.R 100% <100%> (ø) ⬆️
R/utils.R 100% <100%> (ø) ⬆️
R/visualize.R 100% <100%> (ø) ⬆️

@ismayc ismayc changed the title Adding p_value() and get_pvalue() aliases Adding p_value(), conf_int(), and corresponding aliases with improved visualize() Jun 14, 2018
@ismayc ismayc requested a review from andrewpbray July 6, 2018 02:10
@ismayc
Copy link
Collaborator Author

ismayc commented Jul 6, 2018

@andrewpbray There's been quite a few new things added here. Might want to bump to 0.3.0? Just so we are clear on the workflow here. I think it would be best if you could review (in this order):

  1. develop into master in Develop -> master #140 and provide comments/suggestions
  2. This PR and provide comments/suggestions
  3. Ideally merge this into develop and then into master and then send to CRAN by 11:59 PM Pacific time on July 6. That's a lot I know, but I've been working on this a ton over the last few months and want the useR! talk as good as possible. I'll likely be working on that on the flight from Honolulu to Sydney on July 7 - 8 so it would be helpful if I knew what CRAN might look like by then.

@ismayc ismayc merged commit 1917c89 into develop Jul 7, 2018
@ismayc ismayc deleted the p_value branch September 9, 2018 05:35
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants