restrict fit_xy() from working for censored regression models
#445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
approved these changes
Mar 16, 2021
Member
topepo
left a comment
topepo
left a comment
There was a problem hiding this comment.
We can add test cases for this when we move the model definitions to parsnip from censored.
Member
Author
|
PR #449 adds the model spec for |
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #442
Models with the new mode "censored regression" can't use
fit_xy(), they should usefit().surv_regmodels have also been forced to use the formula interfacefit(). The check for that has been moved intofit_xy()fromcheck_xy_interface()which checks the details ofxandy. The corresponding tests forcheck_xy_interface()were removed. The tests for an error when usingfit_xy()with asurv_regmodel are untouched intest_sruv_reg_survreg.Randtest_surv_reg_flexsurv.R.The corresponding tests for models for censored regression are to be added when we have the corresponding model specs in parsnip (#444).