Quosure passthrough #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…descr_spark() helpers.
Quosure passthrough davis
quosure updates
… place rather than in a child env.
…pace is not required (and did not work anyways)
… spec testing to the check_args() generic.
Quosured argument changes
descriptor, documentation, and travis changes
…/parsnip into quosure-passthrough-tests
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
- Coverage 74.43% 71.9% -2.54%
=========================================
Files 30 31 +1
Lines 1991 2235 +244
=========================================
+ Hits 1482 1607 +125
- Misses 509 628 +119
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed
othersargarguments now captured using quosures
Tests are updated for the new approach of capturing arguments as quosures as well as the removal of
others().Instead of creating a new, clean environment, we go back to creating a child of the current environment. The clean environment had issues with some packages not importing (or calling by namespace) functions from
statssuch asmodel.frame.Fixed
glmnetprediction issues. The predict method formodel_fituses the model specification to get thelambdato predictive with. In this branch, all arguments are quosures so this fails. Theglmnet-specific predict method evaluate the specification arguments before predicting.varying_args()now works for complex arguments such assampsize = c(12, varying()).Model wrappers for C5.0, keras, and xgboost are documented.
quantiles added as a prediction type
updated survival models
fixed spark column name nonsense
changed descriptor names
major documentation updates
travis build config changes