stat_bin2d now handles NA in data#448
Conversation
stat_bin2d did not correctly handle NA's in the data. This could be triggered by setting scale limits which did not include the entire range of the data.
R/stat-bin2d.r
Outdated
There was a problem hiding this comment.
Would you mind putting spaces around = please?
There was a problem hiding this comment.
And I was trying to be careful to follow your style too. Fixed this in another commit, as well as others in the same file.
Both the code I added and existing code.
|
Thanks Brian - will pull next time I'm working on ggplot2. |
|
@BrianDiggs Could you add an entry in NEWS? |
Address Issue tidyverse#448 request for news entry related to push request.
|
It was easier to create another pull request with the update to NEWS (#469) because when I branched off to make the fix, NEWS didn't have anyplace to put new entries and I wanted each to apply cleanly. And I can't rebase an already public branch. |
|
For future reference, rebasing public branches actually isn't as bad as commonly believed. I think it'll only cause problems if someone else fetches your branch and starts working off of it. I frequently rebase my pull requests... there was a small discussion about it in #374. |
Address Issue #448 request for news entry related to push request.
|
The commits have been rebased onto master. |
Address Issue tidyverse#448 request for news entry related to push request.
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
3 participants
stat_bin2d did not correctly handle NA's in the data. This could be
triggered by setting scale limits which did not include the entire
range of the data.
This arose from a discussion on the mailing list
https://groups.google.com/d/topic/ggplot2/VAB1wKqwg9w/discussion