ci(sync-files): name synced agnocast_wrapper umbrella nebula_agnocast_wrapper.hpp - #472
Merged
mojomex merged 2 commits intoJul 24, 2026
Merged
Conversation
…_wrapper.hpp Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98
added a commit
to Koichi98/nebula
that referenced
this pull request
Jul 23, 2026
…ier4#472 rename Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98
marked this pull request as ready for review
July 23, 2026 22:44
…ded by nebula_ rename Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
=======================================
Coverage 40.17% 40.17%
=======================================
Files 132 132
Lines 10292 10292
Branches 5399 5399
=======================================
Hits 4135 4135
Misses 3770 3770
Partials 2387 2387
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mojomex
added a commit
that referenced
this pull request
Jul 24, 2026
…nd-written wrapper (Stage 2) (#467) * feat(agnocast_wrapper): adopt synced agnocast_wrapper core, retire hand-written wrapper (Stage 2) Removes the hand-written nebula_agnocast_wrapper.hpp (Method-1) and switches the nebula_hesai decoder_wrapper to the synced umbrella's explicit-node API (NEBULA_CREATE_PUBLISHER2 -> NEBULA_CREATE_PUBLISHER2_ON_NODE, NEBULA_HAS_ANY_SUBSCRIPTIONS -> get_subscription_count() > 0). Nodes stay rclcpp::Node. The synced headers arrive via Stage 1 (#466) sync-files, so they are not in this diff. Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> * refactor(nebula_hesai): use nebula_agnocast_wrapper.hpp include after #472 rename Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> --------- Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com>
mojomex
added a commit
that referenced
this pull request
Jul 24, 2026
* chore: sync files Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * style(pre-commit): autofix * feat(agnocast_wrapper): adopt synced agnocast_wrapper core, retire hand-written wrapper (Stage 2) (#467) * feat(agnocast_wrapper): adopt synced agnocast_wrapper core, retire hand-written wrapper (Stage 2) Removes the hand-written nebula_agnocast_wrapper.hpp (Method-1) and switches the nebula_hesai decoder_wrapper to the synced umbrella's explicit-node API (NEBULA_CREATE_PUBLISHER2 -> NEBULA_CREATE_PUBLISHER2_ON_NODE, NEBULA_HAS_ANY_SUBSCRIPTIONS -> get_subscription_count() > 0). Nodes stay rclcpp::Node. The synced headers arrive via Stage 1 (#466) sync-files, so they are not in this diff. Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> * refactor(nebula_hesai): use nebula_agnocast_wrapper.hpp include after #472 rename Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> --------- Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Koichi Imai <45482193+Koichi98@users.noreply.github.com> Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com>
Koichi98
added a commit
to Koichi98/nebula
that referenced
this pull request
Jul 27, 2026
…or, publish packets via const & - include the post-tier4#472 nebula_agnocast_wrapper.hpp (old autoware_agnocast_wrapper.hpp no longer exists) in decoder_wrapper.{hpp,cpp} - link agnocast_cie_thread_configurator (PRIVATE) in the Agnocast build; cie_thread_factory's Agnocast branch calls agnocast_cie_thread_configurator::spawn_non_ros2_thread - publish raw packets via publish(*msg); the previous ALLOCATE + std::move(*msg) stole a normal-heap buffer, so the payload never entered shared memory (invalid for cross-process Agnocast subscribers) Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98
added a commit
to Koichi98/nebula
that referenced
this pull request
Jul 27, 2026
…, restore cie thread factory - include the post-tier4#472 nebula_agnocast_wrapper.hpp (old autoware_agnocast_wrapper.hpp no longer exists) - publish raw packets via publish(*msg) so the payload is materialized into shared memory (a plain std::move would leave it on the normal heap, invalid for cross-process subscribers) - restore make_cie_thread_factory for the packets publish thread; the migration had dropped it, which would leave that non-ROS thread unmanaged by the Agnocast CIE thread configurator and lose its configured priority/affinity Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Follow-up to the reviewer comment on #467: the synced agnocast_wrapper umbrella header was landing
under an
autoware_*filename. This renames its sync dest tonebula_agnocast_wrapper.hppso themirrored header follows nebula's
nebula_*naming (and conveniently sits at the same path/name as theformer hand-written wrapper, so the sync replaces it in place).
Only the
.github/sync-files.yamlautowarefoundation/autoware.coreblock changes:dest:.../agnocast_wrapper/autoware_agnocast_wrapper.hpp->.../nebula_agnocast_wrapper.hpppre-commandsstepsd 'autoware_agnocast_wrapper.hpp' 'nebula_agnocast_wrapper.hpp'so the mirrored headers' internal
#includeof the umbrella is rewritten to the new name.The upstream source file name (
autoware_agnocast_wrapper.hppin autoware.core) is unchanged; only themirrored copy in nebula is renamed. No source/build changes here.
Review Procedure
Review the
autowarefoundation/autoware.coreblock in.github/sync-files.yaml. The next sync willproduce
nebula_agnocast_wrapper.hppwith its includes rewritten accordingly.Remarks
Adoption of the synced wrapper (retiring the hand-written wrapper, migrating call sites) is tracked in
#467, which will include the matching
#includename.Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks