Skip to content

ci(sync-files): name synced agnocast_wrapper umbrella nebula_agnocast_wrapper.hpp - #472

Merged
mojomex merged 2 commits into
tier4:mainfrom
Koichi98:feat/agnocast-wrapper-nebula-filename
Jul 24, 2026
Merged

ci(sync-files): name synced agnocast_wrapper umbrella nebula_agnocast_wrapper.hpp#472
mojomex merged 2 commits into
tier4:mainfrom
Koichi98:feat/agnocast-wrapper-nebula-filename

Conversation

@Koichi98

Copy link
Copy Markdown
Contributor

PR Type

  • Improvement

Related Links

Description

Follow-up to the reviewer comment on #467: the synced agnocast_wrapper umbrella header was landing
under an autoware_* filename. This renames its sync dest to nebula_agnocast_wrapper.hpp so the
mirrored header follows nebula's nebula_* naming (and conveniently sits at the same path/name as the
former hand-written wrapper, so the sync replaces it in place).

Only the .github/sync-files.yaml autowarefoundation/autoware.core block changes:

  • umbrella dest: .../agnocast_wrapper/autoware_agnocast_wrapper.hpp -> .../nebula_agnocast_wrapper.hpp
  • each entry gains a pre-commands step sd 'autoware_agnocast_wrapper.hpp' 'nebula_agnocast_wrapper.hpp'
    so the mirrored headers' internal #include of the umbrella is rewritten to the new name.

The upstream source file name (autoware_agnocast_wrapper.hpp in autoware.core) is unchanged; only the
mirrored copy in nebula is renamed. No source/build changes here.

Review Procedure

Review the autowarefoundation/autoware.core block in .github/sync-files.yaml. The next sync will
produce nebula_agnocast_wrapper.hpp with its includes rewritten accordingly.

Remarks

Adoption of the synced wrapper (retiring the hand-written wrapper, migrating call sites) is tracked in
#467, which will include the matching #include name.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

…_wrapper.hpp

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
@Koichi98 Koichi98 self-assigned this Jul 23, 2026
Koichi98 added a commit to Koichi98/nebula that referenced this pull request Jul 23, 2026
…ier4#472 rename

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
@Koichi98
Koichi98 marked this pull request as ready for review July 23, 2026 22:44
@Koichi98
Koichi98 requested a review from mojomex July 23, 2026 22:47
…ded by nebula_ rename

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.17%. Comparing base (5740979) to head (6cb912d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   40.17%   40.17%           
=======================================
  Files         132      132           
  Lines       10292    10292           
  Branches     5399     5399           
=======================================
  Hits         4135     4135           
  Misses       3770     3770           
  Partials     2387     2387           
Flag Coverage Δ
nebula_core_ros 43.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojomex mojomex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@mojomex
mojomex merged commit b4d02c2 into tier4:main Jul 24, 2026
94 of 95 checks passed
mojomex added a commit that referenced this pull request Jul 24, 2026
…nd-written wrapper (Stage 2) (#467)

* feat(agnocast_wrapper): adopt synced agnocast_wrapper core, retire hand-written wrapper (Stage 2)

Removes the hand-written nebula_agnocast_wrapper.hpp (Method-1) and switches the nebula_hesai decoder_wrapper to the synced umbrella's explicit-node API (NEBULA_CREATE_PUBLISHER2 -> NEBULA_CREATE_PUBLISHER2_ON_NODE, NEBULA_HAS_ANY_SUBSCRIPTIONS -> get_subscription_count() > 0). Nodes stay rclcpp::Node. The synced headers arrive via Stage 1 (#466) sync-files, so they are not in this diff.

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>

* refactor(nebula_hesai): use nebula_agnocast_wrapper.hpp include after #472 rename

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>

---------

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com>
mojomex added a commit that referenced this pull request Jul 24, 2026
* chore: sync files

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* style(pre-commit): autofix

* feat(agnocast_wrapper): adopt synced agnocast_wrapper core, retire hand-written wrapper (Stage 2) (#467)

* feat(agnocast_wrapper): adopt synced agnocast_wrapper core, retire hand-written wrapper (Stage 2)

Removes the hand-written nebula_agnocast_wrapper.hpp (Method-1) and switches the nebula_hesai decoder_wrapper to the synced umbrella's explicit-node API (NEBULA_CREATE_PUBLISHER2 -> NEBULA_CREATE_PUBLISHER2_ON_NODE, NEBULA_HAS_ANY_SUBSCRIPTIONS -> get_subscription_count() > 0). Nodes stay rclcpp::Node. The synced headers arrive via Stage 1 (#466) sync-files, so they are not in this diff.

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>

* refactor(nebula_hesai): use nebula_agnocast_wrapper.hpp include after #472 rename

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>

---------

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Koichi Imai <45482193+Koichi98@users.noreply.github.com>
Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com>
Koichi98 added a commit to Koichi98/nebula that referenced this pull request Jul 27, 2026
…or, publish packets via const &

- include the post-tier4#472 nebula_agnocast_wrapper.hpp (old autoware_agnocast_wrapper.hpp
  no longer exists) in decoder_wrapper.{hpp,cpp}
- link agnocast_cie_thread_configurator (PRIVATE) in the Agnocast build; cie_thread_factory's
  Agnocast branch calls agnocast_cie_thread_configurator::spawn_non_ros2_thread
- publish raw packets via publish(*msg); the previous ALLOCATE + std::move(*msg) stole a
  normal-heap buffer, so the payload never entered shared memory (invalid for cross-process
  Agnocast subscribers)

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98 added a commit to Koichi98/nebula that referenced this pull request Jul 27, 2026
…, restore cie thread factory

- include the post-tier4#472 nebula_agnocast_wrapper.hpp (old autoware_agnocast_wrapper.hpp
  no longer exists)
- publish raw packets via publish(*msg) so the payload is materialized into shared memory
  (a plain std::move would leave it on the normal heap, invalid for cross-process subscribers)
- restore make_cie_thread_factory for the packets publish thread; the migration had dropped it,
  which would leave that non-ROS thread unmanaged by the Agnocast CIE thread configurator and
  lose its configured priority/affinity

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants