Update data fetcher constructor#59
Merged
rmarianski merged 1 commit intomasterfrom Jan 24, 2017
Merged
Conversation
Member
|
Hmm, it might not be a good idea to set the max connections to be the same as min. Let me look a little closer 🔍 . |
Member
|
I might be off-by-one here, but I think if we set min and max to the same thing, we won't be able to request all N connections because of this pair of lines: https://github.com/psycopg/psycopg2/blob/master/lib/pool.py#L90-L91 |
Member
Author
|
It still looks like we'd be ok to me because that branch will only get triggered if there's nothing in I deployed this branch to dev so we can wait to see if we get any errors in tileserver related to this after some usage. |
Member
|
Yep, you're right. I think we're OK here. |
iandees
approved these changes
Jan 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zerebubuth, @iandees could you review please?
@iandees I'm assuming that it's ok for the minimum and maximum values to be the same for tileserver.