Towards 1.1.0 - #59
Merged
Merged
Conversation
- Move VERSION into new ValidatesOverlap module (lib/validates_overlap/version.rb); OverlapValidator stays the Rails-facing validator class, delete the VERSION file - Rewrite gemspec: version from ValidatesOverlap::VERSION, package only lib/ + README + MIT-LICENSE (no more git ls-files / dummy app in the gem), drop deprecated test_files, depend on activerecord instead of the full rails meta-gem (version floor unchanged at >= 6.0.0), move rails to development dependencies for the dummy app - Migrate the test suite from factory_girl (dead since 2017, cannot load on Ruby 3.4) to factory_bot, converting factories to block syntax - spec_helper: MigrationContext arity switch (Rails 6.1 requires the schema_migration arg, Rails 7.2+ removed it), explicit FactoryBot definition loading, start SimpleCov before the app loads - Dummy app: version-switched enum declaration (Rails 8 removed the keyword form, Rails 6.x lacks the positional form) - Add GitHub Actions matrix: Ruby 3.0-3.4 x Rails 6.1-8.1 (18 cells) with per-Rails gemfiles; Rails <= 7.1 gemfiles pin sqlite3 ~> 1.4 and Rails < 7.1 pin concurrent-ruby < 1.3.5 - Remove dead .travis.yml and Gemfile.rails60; remove obsolete Rakefile last_comment hack All six Rails columns verified green locally: 81 examples, 0 failures, 1 pending (pre-existing xit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
…ails the build
The suite is RSpec; rails/test_help registers minitest autorun, whose at-exit
runner tries to parse RSpec's --pattern flag ("invalid option: --pattern") and
exits 1 after all 81 examples pass. Everything the suite uses comes from
rspec-rails and the dummy app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
defined_enums is keyed by strings, so a scope like `scope: [:kind]` looked up nil and crashed with NoMethodError. Regression-tested via a dummy model whose scope names the enum attribute as a symbol (red before the fix, green after); the existing DocumentWithEnum keeps covering the string-scope form. Same fix as PR #55 by @denmarkmeralpis (Dec 2019). Co-authored-by: Nujian Den Mark Meralpis <denmarkmeralpis@gmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
…etadata CONTRIBUTORS.md thanks Robin Bortlik and lists all merged-PR authors plus the open-issue reporters. Both files also ship in the gem package now. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undefined method[]' for nil:NilClass` #54