Conversation
…ld validation Rails shares ONE OverlapValidator instance per model class. The scope proc runs in the middle of building a record's overlap query, so triggering another validation of the same class from it deterministically reproduces what a concurrent thread does to the shared instance. Against the current stateful validator this test is RED: the overlapping record is reported valid because its existence query runs with the other record's time range. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
…across validations
The per-class validator instance stored sql_conditions/sql_values/scoped_model as
instance state while building and running each query. Concurrent validations of
the same model class overwrote each other mid-build, surfacing intermittently as
ActiveRecord::PreparedStatementInvalid ("missing value for :user_id_value") or as
silently wrong validation results.
The query is now built entirely in locals and passed through the call chain; the
attr_accessors are gone and the protected query-building methods take and return
their inputs. No behavior change for single-threaded use — all 85 existing
examples pass unchanged.
Thanks to Jorge Santos (@jsantos) for the original 2019 report.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 115 116 +1
=========================================
+ Hits 115 116 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ShKZCYJFU7bdDSvRT2FgN1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50