Skip to content

Quarkus Live Update with tilt#20

Merged
nicks merged 3 commits intotilt-dev:masterfrom
bandrade:quarkus-example
May 26, 2020
Merged

Quarkus Live Update with tilt#20
nicks merged 3 commits intotilt-dev:masterfrom
bandrade:quarkus-example

Conversation

@bandrade
Copy link
Contributor

I would like to add this example that is using Quarkus.

Please have review

Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I played around with this a bit. It's very fast!

A couple clarification questions (in case anyone asks us about it):

  1. The trick to use a Persistent Volume for maven caching is clever! But I don't think that's how we would usually advise people to do it. When you tilt down your build, you lose the cache. Is there a mvn command to download the deps as part of the docker build?

  2. Would it make sense to have a quarkus extension?
    https://github.com/tilt-dev/tilt-extensions
    That would make it a bit easier to have people re-use the logic. We should definitely have a buildah extension. (I think it still makes sense to have a working example like this, even if we also have an extension)

@bandrade
Copy link
Contributor Author

bandrade commented May 26, 2020

Nice! I played around with this a bit. It's very fast!

A couple clarification questions (in case anyone asks us about it):

  1. The trick to use a Persistent Volume for maven caching is clever! But I don't think that's how we would usually advise people to do it. When you tilt down your build, you lose the cache. Is there a mvn command to download the deps as part of the docker build?

mvn dependency:go-offline can be used to that matter, I think that would be nice to have everything in the image. But as far as I tested if you run tilt down and tilt up again, the container build would be triggered again, so I think we would have the same steps but in different orders. Please correct me if I'm wrong.

  1. Would it make sense to have a quarkus extension?
    https://github.com/tilt-dev/tilt-extensions
    That would make it a bit easier to have people re-use the logic. We should definitely have a buildah extension. (I think it still makes sense to have a working example like this, even if we also have an extension)

I think that would be nice since some frameworks have different ways to do the same thing, I guess that would help users to identify how to do it with an extension

@nicks nicks merged commit cbdef52 into tilt-dev:master May 26, 2020
@nicks
Copy link
Member

nicks commented May 26, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants