Skip to content

tiltfile: add experimental hotreload support#1060

Merged
nicks merged 1 commit into
masterfrom
nicks/hotreload2
Jan 24, 2019
Merged

tiltfile: add experimental hotreload support#1060
nicks merged 1 commit into
masterfrom
nicks/hotreload2

Conversation

@nicks

@nicks nicks commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @maiamcc,

Please review the following commits I made in branch nicks/hotreload2:

33ead1a (2019-01-24 11:01:27 -0500)
tiltfile: add experimental hotreload support

@nicks
nicks requested review from jazzdan and maiamcc January 24, 2019 16:02
@nicks

nicks commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

background on this:

I was playing around with getting some repos that used nodemon or webpack reload on Tilt, and it was taking a long time to restart the container each time. This was fairly straightforward to add and improved performance a lot.

i don't want to document it or advertise it quite yet (like hold off until we have synclet support for this behavior), but it's going to help with my demo today

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! maybe a test where you verify the calls to dockerClient.RestartContainer?

@nicks

nicks commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

added a test for RestartContainer!

@nicks
nicks merged commit 8a48e13 into master Jan 24, 2019
@nicks
nicks deleted the nicks/hotreload2 branch January 24, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants