tiltfile: store normalized image name on dc_resource for matching against imagesByName#1066
Merged
Conversation
…inst imagesByName
jazzdan
approved these changes
Jan 25, 2019
| return named.String(), nil | ||
| } | ||
|
|
||
| func MustNormalizeRefName(ref string) string { |
Contributor
There was a problem hiding this comment.
This could live in the test package as it's only used there
Contributor
Author
There was a problem hiding this comment.
that makes sense, though i'm inclined to leave it near the function it Must's? 🤷♀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whoops try this one