Skip to content

hud: only quit on ^C#1074

Merged
landism merged 1 commit into
masterfrom
mlandis/ch1437/q-to-quit-is-too-easy-to-hit-accidentally
Jan 30, 2019
Merged

hud: only quit on ^C#1074
landism merged 1 commit into
masterfrom
mlandis/ch1437/q-to-quit-is-too-easy-to-hit-accidentally

Conversation

@landism

@landism landism commented Jan 30, 2019

Copy link
Copy Markdown
Member

This might be annoying for people who have trained themselves to hit q/esc, which could be mitigated by sticking with q/esc and adding a modal instead, but hopefully that'll only happen a couple times and they'll notice the new key in the status bar?

@landism
landism requested review from hyu and nicks January 30, 2019 16:39

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@landism
landism merged commit 6b590f2 into master Jan 30, 2019
@landism
landism deleted the mlandis/ch1437/q-to-quit-is-too-easy-to-hit-accidentally branch January 30, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants