engine: add test for empty Tiltfile#1097
Merged
Merged
Conversation
maiamcc
approved these changes
Feb 1, 2019
maiamcc
left a comment
maiamcc
left a comment
Contributor
There was a problem hiding this comment.
LGTM -- except that that link no longer exists. can you
a. update the error message itself to point to https://docs.tilt.build/tutorial.html and
b. change the assert to just assert the start of the error string, so we can change that url in future w/o breaking the test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.