Skip to content

tiltfile: fix assertManifest and test for docker compose service order#1102

Merged
maiamcc merged 1 commit into
masterfrom
maiamcc/fix-assert-manifest
Feb 2, 2019
Merged

tiltfile: fix assertManifest and test for docker compose service order#1102
maiamcc merged 1 commit into
masterfrom
maiamcc/fix-assert-manifest

Conversation

@maiamcc

@maiamcc maiamcc commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

Hello @landism, @jazzdan,

Please review the following commits I made in branch maiamcc/fix-assert-manifest:

676c110 (2019-02-01 15:51:06 -0500)
fix assertmanifest and test for docker compose service order

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc
maiamcc requested review from jazzdan and landism February 1, 2019 20:52

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maiamcc
maiamcc merged commit 70cd242 into master Feb 2, 2019
@maiamcc
maiamcc deleted the maiamcc/fix-assert-manifest branch February 2, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants