Skip to content

web: Demonstrate what a new experiment looks like#1225

Merged
nicks merged 1 commit into
masterfrom
nicks/ch1694/logs
Mar 6, 2019
Merged

web: Demonstrate what a new experiment looks like#1225
nicks merged 1 commit into
masterfrom
nicks/ch1694/logs

Conversation

@nicks

@nicks nicks commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Hello @landism, @yuindustries,

Please review the following commits I made in branch nicks/ch1694/logs:

cc1205a (2019-02-27 14:58:25 -0500)
web: Demonstrate what a new experiment looks like

9b463e3 (2019-02-27 14:43:23 -0500)
web: add a little react router for starting new experiments

d0555f5 (2019-02-27 12:42:30 -0500)
hud: serve web assets directly from Tilt

@nicks
nicks requested review from hyu and landism February 27, 2019 19:58
@nicks

nicks commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

this is just a very simple experiment that displays the global log. it doesn't do it particularly efficiently but it should be a good base for iteration!

screenshot from 2019-02-27 14-59-55

@nicks
nicks changed the base branch from master to nicks/router February 27, 2019 20:48
@nicks
nicks force-pushed the nicks/ch1694/logs branch from cc1205a to a754e5f Compare March 1, 2019 03:56
@nicks
nicks changed the base branch from nicks/router to master March 1, 2019 03:57
@nicks

nicks commented Mar 1, 2019

Copy link
Copy Markdown
Contributor Author

rebased!

@hyu hyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! An excellent basis to iterate on.

@nicks
nicks merged commit e36b2cb into master Mar 6, 2019
@nicks
nicks deleted the nicks/ch1694/logs branch March 6, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants