engine: rm dead code in podLogManager#1252
Merged
Merged
Conversation
maiamcc
commented
Mar 5, 2019
| } | ||
| } | ||
|
|
||
| func TestLogsTruncatedWhenCanceled(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
turns out this func didn't actually test anything
| t.Fatal(err) | ||
| } | ||
|
|
||
| // Previous log stream has finished, so the first pod watch has been canceled, |
Contributor
Author
|
Rolling back a chunk of changes from #776 -- seems that all that was needed to fix the problem in question was the |
landism
approved these changes
Mar 5, 2019
landism
left a comment
landism
left a comment
Member
There was a problem hiding this comment.
I think we can also delete PodLogWatch.ContainerID?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism, @nicks,
Please review the following commits I made in branch maiamcc/clean-up-pod-log-watch:
c2fc560 (2019-03-05 17:52:39 -0500)
engine: rm dead code in podLogManager
Code review reminders, by giving a LGTM you attest that: